Skip to content

Add styling to details tag #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

Add styling to details tag #235

merged 4 commits into from
Apr 28, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Apr 24, 2025

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/477

Before:
Screenshot 2025-04-25 at 8 39 17 AM

After:
Screenshot 2025-04-25 at 8 38 13 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the enhancement New feature or request label Apr 24, 2025
@lamATnginx lamATnginx self-assigned this Apr 24, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner April 24, 2025 16:22
Copy link
Contributor

@danielledeleo danielledeleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a page to the example site and a screenshot to the PR.

Looks like it breaks sidebar positioning somehow:

Screen.Recording.2025-04-25.at.9.13.52.AM.mov

@lamATnginx
Copy link
Collaborator Author

Please add a page to the example site and a screenshot to the PR.

Looks like it breaks sidebar positioning somehow:
Screen.Recording.2025-04-25.at.9.13.52.AM.mov

The sidebar position is not really breaking as it is following the positioning of being sticky. Before expanding, there is not that much space since I assume the footer is visible in your case, but after expanding, the height of the page increases, so the sidebar also does since it is given more space for sticky to work.

@danielledeleo
Copy link
Contributor

Right, ok. Doesn't feel great though.

@lamATnginx lamATnginx merged commit 4d1df2b into main Apr 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants