Mainframe: Sidebar implemtation #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix chevron sizing Move chevron to right of links Fix nested li top padding Steal 1rem from left main
nginx-jack
changed the title
lamATnginx
approved these changes
May 7, 2025
4 tasks
lamATnginx
reviewed
May 7, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a from scratch sidebar implementation iterating on @danielledeleo branch and design feedback.
It should work like a sidebar, as expected 🤞 .
Takes the
tocfrontmatter into account, to render or not render the table of contents.Product selector and search are removed from the sidebar. The search now lives in the header, and the product selector will likely end up there as well, but it's not part of this PR.
The table of contents is within the sidebar still, and can be hidden/shown.
There are two a11y hidden links for skipping the sidebar entirely, or just skipping the table of contents you're on.
There's also a fix in here for icons, so that they resize properly via css.
I'd like to get this merged with it's current feature set, but there are some
TODOsfor future PRs:overviewpage nodes that have content in their_index.mdfile. This is important, since you can no longer click directly on a node with pages to see a "list" view.a11y skipper for table of contents
For users
a11y skipper for entire sidebar
Screenshots of various states below