Skip to content

Added banner to list if front matter is present #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 29, 2025
Merged

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented May 21, 2025

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/489

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this May 21, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner May 21, 2025 18:04
@lamATnginx lamATnginx added enhancement New feature or request cleanup labels May 21, 2025
@lamATnginx lamATnginx marked this pull request as draft May 21, 2025 18:04
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/262/

@lamATnginx lamATnginx marked this pull request as ready for review May 22, 2025 14:17
@danielledeleo
Copy link
Contributor

I like how the frontmatter works, that's a nice solution. I'd like to see if we can do this without adding another shortcode that is just another way to invoke callouts.

@nginx-jack
Copy link
Collaborator

I like how the frontmatter works, that's a nice solution. I'd like to see if we can do this without adding another shortcode that is just another way to invoke callouts.

Yeah, since it's almost identical to a call out at the moment, I'd call the calllout.html partial from the banner.html partial. Maybe have the banner partial only handle the banner specific things, like the date, reading the markdown file, and then pass it directly to callout.html, since it already calls markdownify, so that case should be handled.

@lamATnginx lamATnginx merged commit 932ab2d into main May 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants