Skip to content

Shortcode: Add nobreak shortcode and usage exampl #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented May 28, 2025

Shortcode: Add nobreak shortcode and usage example.

Example below uses NGINX Plus (nobreak) as an example.

Screenshot 2025-05-28 at 12 53 37 Screenshot 2025-05-28 at 12 53 27 Screenshot 2025-05-28 at 12 53 23

@nginx-jack nginx-jack requested a review from a team as a code owner May 28, 2025 10:14
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/267/

@danielledeleo
Copy link
Contributor

We will need to be careful to defend against layout breaks that aggressive use of this may cause.

Can we ensure that only plain text exists inside this shortcode and generate a build failure if any other element goes inside?

Copy link
Contributor

@danielledeleo danielledeleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as is, but we may want to guard against misuse in the future.

@nginx-jack nginx-jack merged commit d406661 into main May 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants