Redocly: Fix oldframe redocly width #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
lamATnginx
requested changes
May 29, 2025
There was a problem hiding this comment.
The width is interesting as it is highly dependent on the content. Doesn't mean it can't be bounded via setting the width, but I think using vw is not preferred and only works since there are max-width set in the redoc/single.html to prevent overflow. I would prefer % since vw.
nginx-jack
force-pushed
the
fix-oldframe-redocly
branch
from
d19b529 to
638c705
Compare
lamATnginx
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where oldframe was rendering redocly at a fixed small width.