Skip to content

fix: remove return carriage from copied text #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: remove return carriage from copied text #36

merged 1 commit into from
Dec 11, 2023

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented Dec 7, 2023 •
edited
Loading

Proposed changes

bugfix for docs-386
Remove return carriage from copied text as it causes code pasted into a terminal to execute automatically.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

ADubhlaoich
ADubhlaoich approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JTorreG JTorreG merged commit dd04617 into nginxinc:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@JTorreG JTorreG JTorreG approved these changes

@travisamartin travisamartin Awaiting requested review from travisamartin

@LukeBillington LukeBillington Awaiting requested review from LukeBillington

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nginx-jack @ADubhlaoich @JTorreG