Skip to content

fix: order for list pages + navbar improv #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: order for list pages + navbar improv #37

merged 1 commit into from
Dec 14, 2023

Conversation

JTorreG
Copy link
Collaborator

@JTorreG JTorreG commented Dec 14, 2023

Proposed changes

Imports the list-main.html changes from the docs repo to the theme

  • This change makes items in the list pages appear in the same order as they appear in the side navigation

Improves the navigation bar:

  • When browsing a section list-page the navigation will highlight the section and (new) expand it to show the same subsections as the list page is showing:

before:

image

after:

image

Closes DOC-146

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great UX improvements.

@JTorreG JTorreG merged commit df39e17 into main Dec 14, 2023
@JTorreG JTorreG deleted the DOC-391 branch December 14, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants