Skip to content

Add toggle-able sidebar button #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Add toggle-able sidebar button #47

merged 9 commits into from
Feb 12, 2024

Conversation

LukeBillington
Copy link
Member

Proposed changes

Adds a sidebar toggle feature that uses localStorage to keep track of user preferences to display or hide the left navigation bar. This is useful for viewing the API docs and having access to navigation.

Closes #42

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

Screenshots

Screenshot 2024-02-02 at 12 23 14 PM Screenshot 2024-02-02 at 12 23 22 PM ] I have updated any relevant documentation ([`README.md`](https://github.com/nginxinc/nginx-hugo-theme/blob/main/README.md) and [`CHANGELOG.md`](https://github.com/nginxinc/nginx-hugo-theme/blob/main/CHANGELOG.md))

@nginx-jack
Copy link
Collaborator

I'm seeing some issues with the chevron-right. At my normal resolution (3008*1692 - The middle option of scaling with a 4k monitor) - If I zoom in a few clicks it becomes visible.

Screenshot 2024-02-06 at 10 00 32 Screenshot 2024-02-06 at 10 00 18

@JTorreG
Copy link
Collaborator

JTorreG commented Feb 7, 2024

I'm seeing some issues with the chevron-right. At my normal resolution (3008*1692 - The middle option of scaling with a 4k monitor) - If I zoom in a few clicks it becomes visible.

seeing a similar behavior to the one mentioned by Jack.

Browser: Microsoft Edge, zoom 100%
Resolution tested: 2560x1440
image

at Zoom 125%
image

@LukeBillington LukeBillington changed the title Draft: Add toggle-able sidebar button Add toggle-able sidebar button Feb 8, 2024
@LukeBillington LukeBillington merged commit 1605251 into main Feb 12, 2024
@LukeBillington LukeBillington mentioned this pull request Feb 12, 2024
4 tasks
@ADubhlaoich ADubhlaoich deleted the sidebar-collapse branch October 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show/hide toggle for left navbar & configure via frontmatter
4 participants