Skip to content

docs: add shortcodes and CSS #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

docs: add shortcodes and CSS #71

merged 2 commits into from
Aug 22, 2024

Conversation

JTorreG
Copy link
Collaborator

@JTorreG JTorreG commented Aug 21, 2024

Proposed changes

Adds the call-out and before-you-being used in the docs repo to the theme.

Adds the CSS that was used in custom tables for NGINX One to the default styles for all tables.

before:

image

after:

image

Follow ups after merge and release:

  • Remove the shortcodes from the layouts folder in the docs repo
  • Remove the custom styles in the NGINX one docs/branch
  • Bump the theme/rebuild the docs in the docs repo

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@mjang
Copy link
Contributor

mjang commented Aug 21, 2024

While I'm OK and 👍 this, I'd like to see @LukeBillington 's approval before merge.

@JTorreG JTorreG merged commit 5aa7fcc into main Aug 22, 2024
@JTorreG JTorreG deleted the css-shortcode-update branch August 22, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants