Skip to content

chore: renamed class names for cards on n1 landing page #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

chore: renamed class names for cards on n1 landing page #75

merged 1 commit into from
Sep 9, 2024

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

  • Renamed classes for cards in NGINX One product landing page.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

LukeBillington
LukeBillington approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@LukeBillington LukeBillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lamATnginx lamATnginx merged commit d8766b5 into main Sep 9, 2024
@ADubhlaoich ADubhlaoich deleted the n1-landing-fix branch October 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeBillington LukeBillington LukeBillington approved these changes

@JTorreG JTorreG Awaiting requested review from JTorreG

@travisamartin travisamartin Awaiting requested review from travisamartin

@ADubhlaoich ADubhlaoich Awaiting requested review from ADubhlaoich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @LukeBillington