Added CallableParser.HasReturnParameter with suggested optimizations

Author: bahusoid

src/NHibernate/Engine/Query/CallableParser.cs

@@ -37,13 +37,20 @@ public static Detail Parse(string sqlString)
 
 			callableDetail.FunctionName = functionMatch.Groups[1].Value;
 
-			callableDetail.HasReturn = indexOfCall > 0 &&
-										sqlString.IndexOf('?') > 0 &&
-										sqlString.IndexOf('=') > 0 &&
-										sqlString.IndexOf('?') < indexOfCall &&
-										sqlString.IndexOf('=') < indexOfCall;
+			callableDetail.HasReturn = HasReturnParameter(sqlString, indexOfCall);
 
 			return callableDetail;
 		}
+
+		internal static bool HasReturnParameter(string sqlString, int indexOfCall)
+		{
+			int indexOfQuestionMark;
+			int indexOfEqual;
+			return indexOfCall > 0 &&
+					(indexOfQuestionMark = sqlString.IndexOf('?')) > 0 &&
+					(indexOfEqual = sqlString.IndexOf('=')) > 0 &&
+					indexOfQuestionMark < indexOfCall &&
+					indexOfEqual < indexOfCall;
+		}
 	}
 }

src/NHibernate/Engine/Query/ParameterParser.cs

@@ -43,11 +43,7 @@ public static void Parse(string sqlString, IRecognizer recognizer)
 		{
 			// TODO: WTF? "CALL"... it may work for ORACLE but what about others RDBMS ? (by FM)
 			var indexOfCall = sqlString.IndexOf("call", StringComparison.Ordinal);
-			bool hasMainOutputParameter = indexOfCall > 0 &&
-										  sqlString.IndexOf('?') > 0 &&
-										  sqlString.IndexOf('=') > 0 &&
-										  sqlString.IndexOf('?') < indexOfCall &&
-										  sqlString.IndexOf('=') < indexOfCall;
+			bool hasMainOutputParameter = CallableParser.HasReturnParameter(sqlString, indexOfCall);
 			bool foundMainOutputParam = false;
 
 			int stringLength = sqlString.Length;