Remove transient check completly

Author: bahusoid

src/NHibernate/Async/Collection/AbstractPersistentCollection.cs

@@ -93,41 +93,6 @@ public virtual Task ForceInitializationAsync(CancellationToken cancellationToken
 			return Task.CompletedTask;
 		}
 
-		public Task<ICollection> GetQueuedOrphansAsync(string entityName, CancellationToken cancellationToken)
-		{
-			if (cancellationToken.IsCancellationRequested)
-			{
-				return Task.FromCanceled<ICollection>(cancellationToken);
-			}
-			try
-			{
-				if (HasQueuedOperations)
-				{
-					List<object> additions = new List<object>(operationQueue.Count);
-					List<object> removals = new List<object>(operationQueue.Count);
-					for (int i = 0; i < operationQueue.Count; i++)
-					{
-						IDelayedOperation op = operationQueue[i];
-						if (op.AddedInstance != null)
-						{
-							additions.Add(op.AddedInstance);
-						}
-						if (op.Orphan != null)
-						{
-							removals.Add(op.Orphan);
-						}
-					}
-					return GetOrphansAsync(removals, additions, entityName, session, cancellationToken);
-				}
-
-				return Task.FromResult<ICollection>(CollectionHelper.EmptyCollection);
-			}
-			catch (Exception ex)
-			{
-				return Task.FromException<ICollection>(ex);
-			}
-		}
-
 		/// <summary>
 		/// Called before inserting rows, to ensure that any surrogate keys are fully generated
 		/// </summary>
@@ -155,63 +120,6 @@ public virtual Task PreInsertAsync(ICollectionPersister persister, CancellationT
 		/// </summary>
 		public abstract Task<ICollection> GetOrphansAsync(object snapshot, string entityName, CancellationToken cancellationToken);
 
-		/// <summary> 
-		/// Given a collection of entity instances that used to
-		/// belong to the collection, and a collection of instances
-		/// that currently belong, return a collection of orphans
-		/// </summary>
-		protected virtual async Task<ICollection> GetOrphansAsync(ICollection oldElements, ICollection currentElements, string entityName, ISessionImplementor session, CancellationToken cancellationToken)
-		{
-			cancellationToken.ThrowIfCancellationRequested();
-			// short-circuit(s)
-			if (currentElements.Count == 0)
-			{
-				// no new elements, the old list contains only Orphans
-				return oldElements;
-			}
-			if (oldElements.Count == 0)
-			{
-				// no old elements, so no Orphans neither
-				return oldElements;
-			}
-
-			if (currentElements.Cast<object>().SequenceEqual(oldElements.Cast<object>()))
-				return Array.Empty<object>();
-
-			var persister = session.Factory.GetEntityPersister(entityName);
-			IType idType = persister.IdentifierType;
-
-			var currentObjects = new HashSet<object>(idType.GetComparer());
-			foreach (object current in currentElements)
-			{
-				if (current != null)
-				{
-					var id = persister.GetIdentifier(current);
-					if (id != null)
-						currentObjects.Add(id);
-				}
-			}
-
-			List<object> res = new List<object>();
-			// oldElements may contain new elements (one case when session.Save is called on new object with list)
-			foreach (object old in oldElements)
-			{
-				if (old != null)
-				{
-					var id = persister.GetIdentifier(old);
-					if (id != null)
-					{
-						if (!currentObjects.Contains(id) && await (ForeignKeys.IsNotTransientSlowAsync(persister.EntityName, old, Session, cancellationToken)).ConfigureAwait(false))
-						{
-							res.Add(old);
-						}
-					}
-				}
-			}
-
-			return res;
-		}
-
 		public async Task IdentityRemoveAsync(IList list, object obj, string entityName, ISessionImplementor session, CancellationToken cancellationToken)
 		{
 			cancellationToken.ThrowIfCancellationRequested();

src/NHibernate/Async/Collection/Generic/PersistentGenericBag.cs

@@ -84,8 +84,7 @@ public override Task<ICollection> GetOrphansAsync(object snapshot, string entity
 			}
 			try
 			{
-				var sn = (ICollection) snapshot;
-				return GetOrphansAsync(sn, (ICollection) _gbag, entityName, Session, cancellationToken);
+				return Task.FromResult<ICollection>(GetOrphans(snapshot, entityName));
 			}
 			catch (Exception ex)
 			{

src/NHibernate/Async/Collection/Generic/PersistentGenericIdentifierBag.cs

@@ -163,8 +163,7 @@ public override Task<ICollection> GetOrphansAsync(object snapshot, string entity
 			}
 			try
 			{
-				var sn = (ISet<SnapshotElement>)GetSnapshot();
-				return GetOrphansAsync(sn.Select(x => x.Value).ToArray(), (ICollection) _values, entityName, Session, cancellationToken);
+				return Task.FromResult<ICollection>(GetOrphans(snapshot, entityName));
 			}
 			catch (Exception ex)
 			{

src/NHibernate/Async/Collection/Generic/PersistentGenericList.cs

@@ -38,8 +38,7 @@ public override Task<ICollection> GetOrphansAsync(object snapshot, string entity
 			}
 			try
 			{
-				var sn = (IList<T>)snapshot;
-				return GetOrphansAsync((ICollection)sn, (ICollection) WrappedList, entityName, Session, cancellationToken);
+				return Task.FromResult<ICollection>(GetOrphans(snapshot, entityName));
 			}
 			catch (Exception ex)
 			{

src/NHibernate/Async/Collection/Generic/PersistentGenericMap.cs

@@ -38,8 +38,7 @@ public override Task<ICollection> GetOrphansAsync(object snapshot, string entity
 			}
 			try
 			{
-				var sn = (IDictionary<TKey, TValue>) snapshot;
-				return GetOrphansAsync((ICollection)sn.Values, (ICollection)WrappedMap.Values, entityName, Session, cancellationToken);
+				return Task.FromResult<ICollection>(GetOrphans(snapshot, entityName));
 			}
 			catch (Exception ex)
 			{

src/NHibernate/Async/Collection/Generic/PersistentGenericSet.cs

@@ -39,12 +39,7 @@ public override Task<ICollection> GetOrphansAsync(object snapshot, string entity
 			}
 			try
 			{
-				var sn = new SetSnapShot<T>((IEnumerable<T>)snapshot);
-
-				// TODO: Avoid duplicating shortcuts and array copy, by making base class GetOrphans() more flexible
-				if (WrappedSet.Count == 0) return Task.FromResult<ICollection>(sn);
-				if (((ICollection)sn).Count == 0) return Task.FromResult<ICollection>(sn);
-				return GetOrphansAsync(sn, WrappedSet.ToArray(), entityName, Session, cancellationToken);
+				return Task.FromResult<ICollection>(GetOrphans(snapshot, entityName));
 			}
 			catch (Exception ex)
 			{

src/NHibernate/Async/Collection/IPersistentCollection.cs

@@ -92,9 +92,6 @@ public partial interface IPersistentCollection
 		/// </summary>
 		Task<IEnumerable> GetDeletesAsync(ICollectionPersister persister, bool indexIsFormula, CancellationToken cancellationToken);
 
-		/// <summary> Get the "queued" orphans</summary>
-		Task<ICollection> GetQueuedOrphansAsync(string entityName, CancellationToken cancellationToken);
-
 		/// <summary>
 		/// Called before inserting rows, to ensure that any surrogate keys are fully generated
 		/// </summary>

src/NHibernate/Async/Engine/Cascade.cs

@@ -288,7 +288,7 @@ private async Task DeleteOrphansAsync(string entityName, IPersistentCollection p
 			}
 			else
 			{
-				orphans = await (pc.GetQueuedOrphansAsync(entityName, cancellationToken)).ConfigureAwait(false);
+				orphans = pc.GetQueuedOrphans(entityName);
 			}
 
 			foreach (object orphan in orphans)

src/NHibernate/Collection/AbstractPersistentCollection.cs

@@ -735,15 +735,15 @@ protected virtual ICollection GetOrphans(ICollection oldElements, ICollection cu
 			}
 
 			List<object> res = new List<object>();
-			// oldElements may contain new elements (one case when session.Save is called on new object with list)
+			// oldElements may contain new elements (one case when session.Save is called on new object with collection filled with new objects)
 			foreach (object old in oldElements)
 			{
 				if (old != null)
 				{
 					var id = persister.GetIdentifier(old);
 					if (id != null)
 					{
-						if (!currentObjects.Contains(id) && ForeignKeys.IsNotTransientSlow(persister.EntityName, old, Session))
+						if (!currentObjects.Contains(id))
 						{
 							res.Add(old);
 						}