Upgrade MySql client and remove allowed failures on CI builds (#2501)

* Register missing keywords for MySQLDialect

Author: bahusoid

.travis.yml

@@ -1,8 +1,8 @@
-dist: trusty
+os: linux
+dist: xenial
 language: csharp
 mono: none
 dotnet: 2.1.300
-sudo: required
 services:
   - mysql
   - postgresql
@@ -13,25 +13,22 @@ env:
   - DB=Firebird 
   - DB=MySQL CONNECTION_STRING="Server=127.0.0.1;Uid=root;Database=nhibernate;Old Guids=True;"   
   - DB=SQLite 
-matrix:
-  allow_failures:
-    - env: DB=MySQL CONNECTION_STRING="Server=127.0.0.1;Uid=root;Database=nhibernate;Old Guids=True;"
 before_install:
-  - curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
-  - curl https://packages.microsoft.com/config/ubuntu/14.04/prod.list | sudo tee /etc/apt/sources.list.d/microsoft.list
   - sudo apt-get update -qq
   - sudo apt-get install -y powershell 
   - |-
     if [[ "$DB" == "MySQL" ]]
     then
-      echo -e '[server]\nlower_case_table_names=1' | sudo tee -a /etc/mysql/my.cnf
+      echo -e '[server]\nlower_case_table_names=1\n[mysqld]\ncharacter-set-server=utf8\ncollation-server=utf8_general_ci' | sudo tee -a /etc/mysql/my.cnf
       sudo service mysql restart
     fi
   - |-
     if [[ "$DB" == "Firebird" ]]
     then
-      sudo apt-get install -y libicu-dev libtommath-dev curl
-      curl -L -O https://github.com/FirebirdSQL/firebird/releases/download/R3_0_5/Firebird-3.0.5.33220-0.amd64.tar.gz
+      sudo apt-get install -y libtommath-dev
+      # This would be required on bionic and above
+      # sudo ln -s /usr/lib/x86_64-linux-gnu/libtommath.so.1 /usr/lib/x86_64-linux-gnu/libtommath.so.0
+      wget -q https://github.com/FirebirdSQL/firebird/releases/download/R3_0_5/Firebird-3.0.5.33220-0.amd64.tar.gz
       tar xzvf Firebird-3.0.5.33220-0.amd64.tar.gz
       pushd Firebird-3.0.5.33220-0.amd64
         sudo ./install.sh -silent   
@@ -41,7 +38,7 @@ before_install:
       echo -e "nhibernate = /tmp/firebird/nhibernate.fdb" | sudo tee -a /opt/firebird/databases.conf
       echo -e "AuthServer = Srp\nAuthClient = Srp\nUserManager = Srp\nWireCrypt = Enabled" | sudo tee -a /opt/firebird/firebird.conf
       sudo /opt/firebird/bin/gsec -modify SYSDBA -pw masterkey -admin yes
-      sudo service firebird restart
+      sudo systemctl restart firebird-superserver
     fi
 before_script:
   - if [[ "$DB" == "SqlServer2008" ]]; then docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=P@ssw0rd" -e "MSSQL_PID=Express" -p 1433:1433 -d --name sqlexpress microsoft/mssql-server-linux:latest; fi

appveyor.yml

@@ -13,9 +13,6 @@ environment:
 init:
     # Required for having windows endlines in sources zip
     - git config --global core.autocrlf true
-matrix:
-  allow_failures:
-  - DB: MySQL
 build: off
 before_test:
 - ps: |-

src/NHibernate.Test/NHibernate.Test.csproj

@@ -65,6 +65,7 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.1" />
     <PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="6.3.0" />
     <PackageReference Include="Npgsql" Version="4.0.3" />
+    <PackageReference Include="MySql.Data" Version="8.0.22" />
   </ItemGroup>
   <ItemGroup Condition="$(NhNetFx)">
     <Reference Include="System.Configuration" />
@@ -74,7 +75,6 @@
     <Reference Include="System.Data.OracleClient" />
     <PackageReference Include="Microsoft.SqlServer.Compact" Version="4.0.8876.1" />
     <PackageReference Include="Oracle.ManagedDataAccess" Version="12.1.2400" />
-    <PackageReference Include="MySql.Data" Version="6.9.11" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)'=='netcoreapp2.0'">
     <PackageReference Include="System.CodeDom" Version="4.4.0" />
@@ -83,7 +83,6 @@
     <PackageReference Include="System.Data.Odbc" Version="4.5.0" />
     <PackageReference Include="System.Net.NameResolution" Version="4.3.0" />
     <PackageReference Include="NUnitLite" Version="3.12.0" />
-    <PackageReference Include="MySql.Data" Version="6.10.6" />
   </ItemGroup>
   <ItemGroup Condition=" '$(NuGetPackageRoot)' != '' ">
     <NativeBinaries Include="$(NuGetPackageRoot)microsoft.sqlserver.compact\4.0.8876.1\NativeBinaries\**\*.*" />

src/NHibernate/Dialect/MySQLDialect.cs

@@ -155,6 +155,7 @@ public MySQLDialect()
 			"float8",
 			"force",
 			"fulltext",
+			"goto",
 			"high_priority",
 			"hour_microsecond",
 			"hour_minute",
@@ -170,6 +171,7 @@ public MySQLDialect()
 			"key",
 			"keys",
 			"kill",
+			"label",
 			"limit",
 			"linear",
 			"lines",
@@ -179,6 +181,7 @@ public MySQLDialect()
 			"longblob",
 			"longtext",
 			"low_priority",
+			"master_ssl_verify_server_cert",
 			"mediumblob",
 			"mediumint",
 			"mediumtext",
@@ -207,6 +210,7 @@ public MySQLDialect()
 			"second_microsecond",
 			"separator",
 			"show",
+			"shutdown",
 			"spatial",
 			"sql_big_result",
 			"sql_calc_found_rows",