Upgrade MySql client and remove allowed failures on CI builds #2501

bahusoid · 2020-08-29T18:14:17Z

They claim issue is no longer reproduced on latest client: https://bugs.mysql.com/bug.php?id=90086

hazzik · 2020-08-29T19:13:54Z

It is fixed in .22 which is not released yet. I’m waiting for the release.

…rested in)

hazzik · 2020-10-20T05:31:44Z

@bahusoid still does not work

This is what I was trying to fix:

Failed : NHibernate.Test.TypesTest.StringTypeFixtureAsync.InsertUnicodeValueAsync

  String lengths are both 53. Strings differ at index 0.

  Expected: "길동 최고 新闻 地图 ます プル éèêëîïôöõàâäåãçùûü бджзй αβ ខគឃ ضذخ"

  But was:  "?? ?? ?? ?? ?? ?? éèêëîïôöõàâäåãçùûü ????? aß ??? ???"

  -----------^

   at NHibernate.Test.TypesTest.StringTypeFixtureAsync.InsertUnicodeValueAsync() in /home/travis/build/nhibernate/nhibernate-core/src/NHibernate.Test/Async/TypesTest/StringTypeFixture.cs:line 68

bahusoid · 2020-10-20T05:44:17Z

This is what I was trying to fix

I got it. But it failed the same with you changes, so I assumed that such characters are 4-bytes long so changed to UTF8mb4. This issue is gone with this change . But other tests now failed with new error like

NHibernate.Test.SubselectFetchTest.SubselectFetchFixture
NHibernate.HibernateException : Specified key was too long; max key length is 767 bytes
  ----> MySql.Data.MySqlClient.MySqlException : Specified key was too long; max key length is 767 bytes

hazzik · 2020-10-21T11:42:51Z

Ok. Combination of utf8_general_ci and mysql 5.7 has fixed the MySQL issues. The only problem that MySQL 5.7 is not supported on trusty. Upgrade to bionic/xenial, unfortunately, breaks Firebird.

bahusoid · 2020-10-21T12:45:20Z

Combination of utf8_general_ci and mysql 5.7

I was close :) Did you get why no explicit changes are required for appveyour?

Upgrade to bionic/xenial, unfortunately, breaks Firebird.

Hm.. I made a quick search and found seems to working Firebird installation on xenial travis:
https://github.com/asfernandes/node-firebird-drivers/blob/7fddf29970066b185a580e3f2dd26cbc0b6e6848/.travis.yml

Seems the relevant parts:
https://github.com/asfernandes/node-firebird-drivers/blob/7fddf29970066b185a580e3f2dd26cbc0b6e6848/.travis.yml#L18-L20
https://github.com/asfernandes/node-firebird-drivers/blob/7fddf29970066b185a580e3f2dd26cbc0b6e6848/.travis.yml#L35-L38

hazzik · 2020-10-21T18:54:34Z

Did you get why no explicit changes are required for appveyor?

Because AppVeyor already runs 5.7 with utf8_general_ci collation.

hazzik · 2020-10-21T19:03:27Z

Seems the relevant parts

First link is what we do but with curl instead of nuget.

The second one is what we also have.

I think usermod command is the key.

hazzik · 2020-10-21T20:11:51Z

I think usermod command is the key.

~~It should be. I've used clean docker image of ubuntu:xenial and Firebird works there using our steps. The difference is that in docker everything runs under root user. Here as travis.~~

UPD: no effect.

hazzik · 2020-10-22T01:28:20Z

.travis.yml

 language: csharp
 mono: none
 dotnet: 2.1.300
-sudo: required


This option is obsolete

hazzik · 2020-10-22T01:28:35Z

.travis.yml

 before_install:
-  - curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
-  - curl https://packages.microsoft.com/config/ubuntu/14.04/prod.list | sudo tee /etc/apt/sources.list.d/microsoft.list


hazzik · 2020-10-22T01:28:49Z

.travis.yml

      sudo service mysql restart
    fi
  - |-
    if [[ "$DB" == "Firebird" ]]
    then
-      sudo apt-get install -y libicu-dev libtommath-dev curl


libicu-dev and curl are already installed so no point to install them again.

Why did you change it back to libtommath-dev? I suspect with libtommath0 hacky stuff below with ln wouldn't be required for bionic and above. Or am I wrong?

The libtommath-dev references either libtommath0 or libtommath1 depending on the distributive. 16.04 is the last version which will include libtommath0. The 18.04 and above uses libtommath1.

Firebird 3.x is built against libtommath0 and they refuse to rebuild it to libtommath1, so the ln will be required in 18.04 or above when using the official distribution.

However, it seems that 18.04 and above have Firebird 3.0 in the apt.

hazzik · 2020-10-22T01:29:01Z

.travis.yml

+      sudo apt-get install -y libtommath-dev
+      # This would be required on bionic and above
+      # sudo ln -s /usr/lib/x86_64-linux-gnu/libtommath.so.1 /usr/lib/x86_64-linux-gnu/libtommath.so.0
+      wget -q https://github.com/FirebirdSQL/firebird/releases/download/R3_0_5/Firebird-3.0.5.33220-0.amd64.tar.gz


curl -L -O URL and wget URL do exactly same. I decided to leave wget as it is a standard GNU utility.

hazzik · 2020-10-22T01:29:18Z

.travis.yml

@@ -41,7 +37,7 @@ before_install:
      echo -e "nhibernate = /tmp/firebird/nhibernate.fdb" | sudo tee -a /opt/firebird/databases.conf
      echo -e "AuthServer = Srp\nAuthClient = Srp\nUserManager = Srp\nWireCrypt = Enabled" | sudo tee -a /opt/firebird/firebird.conf
      sudo /opt/firebird/bin/gsec -modify SYSDBA -pw masterkey -admin yes
-      sudo service firebird restart
+      sudo systemctl restart firebird-superserver


The reason it was failing is because the service name on 3.0.x has changed. Probably 14.04 has some residue service definitions for firebird service and so it was working as intended.

Upgrade MySql client and remove allowed failures on CI builds

73166e5

bahusoid closed this Aug 29, 2020

bahusoid added the r: Rejected label Aug 29, 2020

hazzik reopened this Aug 30, 2020

hazzik removed the r: Rejected label Aug 30, 2020

hazzik changed the title ~~Upgrade MySql client and remove allowed failures on CI builds~~ WIP Upgrade MySql client and remove allowed failures on CI builds Aug 30, 2020

hazzik marked this pull request as draft August 31, 2020 22:46

hazzik changed the title ~~WIP Upgrade MySql client and remove allowed failures on CI builds~~ Upgrade MySql client and remove allowed failures on CI builds Aug 31, 2020

Update to .22 (does not exist yet, but this is the version we're inte…

9681a20

…rested in)

hazzik marked this pull request as ready for review October 19, 2020 19:45

hazzik added 2 commits October 20, 2020 08:46

Merge branch 'master' into dep

75ed355

Register missing keywords

fc2ee47

bahusoid force-pushed the dep branch from ccbecbe to 663fb57 Compare October 20, 2020 08:10

This comment has been minimized.

Sign in to view

hazzik force-pushed the dep branch from 246db81 to a74ef1b Compare October 21, 2020 08:58

hazzik previously approved these changes Oct 21, 2020

View reviewed changes

hazzik dismissed their stale review via 79796bb October 21, 2020 09:25

hazzik force-pushed the dep branch from 0c581c0 to 216ed18 Compare October 21, 2020 11:58

bahusoid force-pushed the dep branch from d44ca31 to 5fe0fc2 Compare October 21, 2020 18:53

bahusoid force-pushed the dep branch from 5fe0fc2 to 37bd99d Compare October 21, 2020 18:57

Set collation to utf8_general_ci

1782aaa

hazzik force-pushed the dep branch from be478ad to d2be87f Compare October 22, 2020 01:22

hazzik approved these changes Oct 22, 2020

View reviewed changes

hazzik previously approved these changes Oct 22, 2020

View reviewed changes

hazzik dismissed their stale review via 8639ddc October 22, 2020 02:29

Run linux tests on Ubuntu 16.04

03167e0

hazzik force-pushed the dep branch from 8639ddc to 03167e0 Compare October 22, 2020 02:30

hazzik added c: Tests p: Lowest t: Task labels Oct 22, 2020

hazzik added this to the next minor milestone Oct 22, 2020

hazzik approved these changes Oct 22, 2020

View reviewed changes

hazzik merged commit ef4f4a4 into nhibernate:master Oct 22, 2020

hazzik added the r: Fixed label Oct 22, 2020

This comment has been minimized.

Sign in to view

Upgrade MySql client and remove allowed failures on CI builds #2501

Upgrade MySql client and remove allowed failures on CI builds #2501

Uh oh!

Conversation

bahusoid commented Aug 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazzik commented Aug 29, 2020

Uh oh!

hazzik commented Oct 20, 2020

Uh oh!

bahusoid commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

hazzik commented Oct 21, 2020

Uh oh!

bahusoid commented Oct 21, 2020

Uh oh!

hazzik commented Oct 21, 2020

Uh oh!

hazzik commented Oct 21, 2020

Uh oh!

hazzik commented Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazzik Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

hazzik Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

hazzik Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

bahusoid Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

hazzik Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

hazzik Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

hazzik Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

bahusoid commented Aug 29, 2020 •

edited

Loading

bahusoid commented Oct 20, 2020 •

edited

Loading

hazzik commented Oct 21, 2020 •

edited

Loading