NH-2888 - Add support to ICriteria to eager fetch lazy properties #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows fetching of root entity, one-to-one and many-to-one associations
|
Large patch... |
| @@ -1005,5 +1037,16 @@ public System.Type GetRootEntityTypeIfAvailable() | |||
| return persistentClass; | |||
| throw new HibernateException("Cannot provide root entity type because this criteria was initialized with an entity name."); | |||
| } | |||
|
|
|||
| public LazyPropertyFetchMode GetFetchAllProperties(string path) | |||
There was a problem hiding this comment.
Seems like this should be GetLazyPropertyFetchMode(path) for consistency.
|
Would this also support the QueryOver API? |
hazzik
changed the title
1 task
|
Opened new pr #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables control for eager fetching of lazy properties for the root entity, one-to-one and many-to-one associations when using
ICriteriaqueries. The new API is as follows:ICriteria.SetLazyPropertyFetchMode(LazyPropertyFetchMode mode)This affects the current ICriteria instance
ICriteria.SetLazyPropertyFetchMode(string associationPath, LazyPropertyFetchMode mode)This affects the lazy loading of the specified associationPath (typically a one-to-one).
where mode is either
Default: Standard behaviour to lazy load propertiesSelect: Eager fetch as part of the initial select (using naming conventions from other enums)I chose an enum, as it allows more flexibility in expanding the features later, such as a
SelectAllto eager fetch all one-to-one's that are not lazy loaded.Unit tests have been created to verify behaviour under NH-2888.