#750 - AliasToBean failure, test case and fix #1380
Conversation
| { | ||
| private int _orderLineId; | ||
| private Order _order; | ||
| private Product _product; |
There was a problem hiding this comment.
Tab/spaces mixup. Needs reformat (like CTRL+K CTRL+D).
| { | ||
| public class Order | ||
| { | ||
| private readonly ISet<OrderLine> _orderLines; |
There was a problem hiding this comment.
Space formatted, should be reformatted with tabs for complying with guidelines and general formatting of NHibernate source code.
| using NHibernate.Transform; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace NHibernate.Test.NHSpecificTest.NH0750 |
There was a problem hiding this comment.
|
Regression introduced by 9491f57, the check on |
fredericDelaporte
force-pushed
the
master
branch
from
7c5a3fb to
a87a23b
Compare
| using System.Threading; | ||
|
|
||
| [TestFixture] | ||
| public class FixtureAsync : BugTestCase |
There was a problem hiding this comment.
Its generation was forgotten. See this section of contributing.
There was a problem hiding this comment.
OOPS! It was very hectic to work with VS2017 since it keeps throwing itself into NOT RESPONDING state for my install while I add/edit/rename files in test project. Would keep it in mind if needed to write another one.
There was a problem hiding this comment.
No troubles. Yes VS2017 is currently quite bad at handling large projects migrated to its new csproj format. That is why I had mentioned Rider, which does quite better. But maybe things will start to be better with changes like dotnet/msbuild#2572.
About writing another one, you will need to clean your master branch. But you should do it only after this PR is closed, otherwise you will need to open a new one from a dedicated branch this time.
For cleaning, in case you need instructions, it could be something like:
- Branch away changes done on master if you want to keep them. Assuming you are currently on master,
git branch newBranch. - Still on master, reset it hard
git reset --hard head~x, where x is the number of commits to remove (2 currentlygit reset --hard head~2). - Force push it to your remote
git push -f.
There was a problem hiding this comment.
Thanks for the detailed instructions. I will wait for this PR to close.
| } | ||
| } | ||
|
|
||
| protected override void OnTearDown() |
There was a problem hiding this comment.
This was missing. Deleting all data is required by our tests, otherwise it is considered as a teardown failure.
| @@ -121,6 +121,10 @@ public override IList TransformList(IList collection) | |||
| /// same visibility and inheritance depth.</exception> | |||
| private void SetProperty(string alias, object value, object resultObj) | |||
| { | |||
| if (alias == null) | |||
| // Grouping properties in criteria are selected without alias, just ignore them. | |||
| return; | |||
There was a problem hiding this comment.
The fix. Reintroduces the check removed here without us spotting it and questioning it.
fredericDelaporte
force-pushed
the
master
branch
from
a87a23b to
0068255
Compare
fredericDelaporte
changed the title
…ues/750
I have created the unit test to demonstrate exception happening due to AliasToBean result transformer. The related issue is #750