Skip to content

Documentation fixes #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2017
Merged

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Oct 20, 2017

Remove references to an obsolete configuration section since NHibernate 2.0.0 (NH-1087), and clarifies system-level properties.

Fixes #1386.

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Oct 23, 2017

The cache settings are documented as of NHibernate.Caches 5.1.0, which I intend to publish soon (now published).

be disabled.
</para>
<para>
This is a very special system-level property. It can only bet set through an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bet anymore.

@fredericDelaporte fredericDelaporte force-pushed the EvenMoreDocFixes branch 3 times, most recently from 76c29d3 to 47b3fbf Compare October 26, 2017 10:41
@fredericDelaporte
Copy link
Member Author

Rebased, some more typo fixed, backported css changes.

@hazzik
Copy link
Member

hazzik commented Oct 26, 2017

@fredericDelaporte I think the PRs need to be as targeted as possible (eg, try to fix one issue at a time)

@fredericDelaporte
Copy link
Member Author

I tend to group by subjects (here a bunch of documentation fixes) due to those factors:

  • Builds are long. We have currently more than 24h of builds queued according to TeamCity. Each PR triggers its build, while commits grouped in a PR may not do that (if not pushed one by one with waiting for the build to start on each).
  • Stale PR merges are blocked, so we have to update them at each merge of other PR (or use admin privilege). The more we have PR, the more updates we do on them, the more builds we add.

Having separated commits still allows to distinguish the sub-subjects.

Doing 4 to 6 PR instead of this single one looks to me as a bit overkill for those documentation fixes.

@ngbrown
Copy link
Contributor

ngbrown commented Oct 26, 2017

Maybe the TeamCity server could skip all the per-db-server tests if the changes are just documentation. This could be done with VCS trigger rules. The GitHub "Required" tests may have to be scaled back to prevent merges from being blocked.

@hazzik
Copy link
Member

hazzik commented Oct 27, 2017

I've excluded doc/** from the DB builds as @ngbrown suggested

@fredericDelaporte
Copy link
Member Author

Thanks for the fixes, rebased and squashed.

@hazzik hazzik changed the title Even more doc fixes Documentation fixes Oct 31, 2017
- Obsolete since v2.0.0
- Obsoleted in NH-1087
@hazzik hazzik merged commit 0891c13 into nhibernate:master Oct 31, 2017
@fredericDelaporte fredericDelaporte deleted the EvenMoreDocFixes branch October 31, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants