Preserves the stack trace when unwrapping TargetInvocationException #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fredericDelaporte
commented
Nov 18, 2017
fredericDelaporte
commented
- Also follow up to NH-3500 which was only partially fixed.
- Fixes Normalize TargetInvocationException unwrapping #1441
* Also follow up to NH-3500 which was only partially fixed. * Fixes nhibernate#1441
There was a problem hiding this comment.
There are many other unguarded calls to MethodBase.Invoke which may cause a TargetInvocationException.
I have not change them because those other ones should yield that exception in a consistent way, meaning code catching them is expecting the TargetInvocationException.
The only unwrapping added concerns a non consistent case, where the exception could be sometimes wrapped in a TargetInvocationException or not, depending on whether the entity was proxified or not.
| throw ReflectHelper.UnwrapTargetInvocationException(ex); | ||
| } | ||
| return returnValue; | ||
| return info.InvokeMethodOnTarget(); |
There was a problem hiding this comment.
Unwrapping moved into InvokeMethodOnTarget, which is called two times in NHibernate code: here and a couple of lines above here.
hazzik
approved these changes
Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.