-
Notifications
You must be signed in to change notification settings - Fork 933
New StaticProxyFactoryFactory #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c48beb8
Implement new StaticProxyFactoryFactory
hazzik 9cc5161
Fix tests
hazzik de78104
Merge branch 'master' into proxy-refactoring
hazzik b4bfc90
Fix comments
hazzik bf80568
Code cleanup
hazzik 64e4b57
Fix comments
hazzik fa51673
Code review fixes
hazzik 01ed700
Mark another method as private
hazzik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
using NHibernate.Proxy; | ||
|
||
namespace NHibernate.Bytecode | ||
{ | ||
public class StaticProxyFactoryFactory : IProxyFactoryFactory | ||
{ | ||
internal static StaticProxyFactoryFactory Instance = new StaticProxyFactoryFactory(); | ||
|
||
public IProxyFactory BuildProxyFactory() => new StaticProxyFactory(); | ||
|
||
public IProxyValidator ProxyValidator => new DynProxyTypeValidator(); | ||
|
||
public bool IsInstrumented(System.Type entityClass) => true; | ||
|
||
public bool IsProxy(object entity) => entity is INHibernateProxy; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
using System; | ||
using NHibernate.Engine; | ||
|
||
namespace NHibernate.Proxy | ||
{ | ||
[Serializable] | ||
internal sealed class LiteLazyInitializer : AbstractLazyInitializer | ||
{ | ||
internal LiteLazyInitializer(string entityName, object id, ISessionImplementor session, System.Type persistentClass) | ||
: base(entityName, id, session) | ||
{ | ||
PersistentClass = persistentClass; | ||
} | ||
|
||
public override System.Type PersistentClass { get; } | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For enforcing the singleton pattern, I would define a private default constructor.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a small memory optimization. I don't want to enforce the singleton pattern here. And, in fact, we cannot enforce it, as
StaticProxyFactoryFactory
can be manually configured as a proxy factory factory and will require the public constructor to be creatable by reflection.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I forgot to think about configuration.