Fix ProxyFactory cache #1454
Merged
Fix ProxyFactory cache #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to include into 5.1 instead. As #1451 now uses completely different approach, I’m going to remove from there changes related to this PR. |
hazzik
force-pushed
the
entity-key-allocations
branch
2 times, most recently
from
a57a49e to
41f16d0
Compare
- use a correct implementation of cache - reduce number of allocations of ProxyCacheEntry - reduce memory flow
hazzik
force-pushed
the
entity-key-allocations
branch
from
41f16d0 to
ee06c89
Compare
hazzik
commented
Dec 3, 2017
| using NHibernate.Proxy; | ||
| using NHibernate.Proxy.DynamicProxy; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace NHibernate.Test.NHSpecificTest.NH3954 | ||
| { | ||
| [TestFixture, Explicit("Demonstrates bug impact on cache, but which tests will fail is a bit unpredictable")] | ||
| [TestFixture, Explicit("Demonstrates bug impact on cache, but which tests will fail is a bit unpredictable"), Obsolete] |
There was a problem hiding this comment.
Had to mark it as obsolete as ProxyCache class now is marked obsolete
| private int _hashCode1; | ||
| private int _hashCode2; | ||
|
|
||
| private static readonly FieldInfo InternalCacheField = | ||
| typeof(ProxyCache).GetField("cache", BindingFlags.Static | BindingFlags.NonPublic); | ||
| typeof(ProxyFactory).GetField("_cache", BindingFlags.Static | BindingFlags.NonPublic); |
There was a problem hiding this comment.
The field has moved to ProxyFactory
fredericDelaporte
previously approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProxyCache has a weird, inefficient and incorrect implementation. Replaced with just ConcurrentDictionary.
Removed unnecessary collections manipulations to get some perf boost.
Also, previously there were 4 instances of ProxyCacheEntry created per one call to CreateProxyType. But the constructor of ProxyCacheEntry is expensive in terms of both memory and CPU.