Disable session tracking by default #1461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
force-pushed
the
activate1391
branch
3 times, most recently
from
fc133fe to
0de0083
Compare
|
Since the performance of SessionIdLoggingContext has become a norm now, I do not see the urge to include this into 5.1. |
|
@fredericDelaporte why close? |
|
Not doing it soon, not sure the PR will stay valid till we start 6.0, and this is now only a 1% gain or something like that, so well, is it worth it? |
|
Ok. I just retargeted to 6.0 just in case we still will want to do so. |
|
Causes a weird progress of 6.0, so going to reopen, and fix the test by the way. |
fredericDelaporte
force-pushed
the
activate1391
branch
from
0de0083 to
a62a9a1
Compare
|
Maybe sometime in the far future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables #1391 by default (enabling a deactivation...), as proposed in #1446.
This is a grey area change for a minor: it will breaks NHProf users until they adjust their configuration for re-enabling it. (@ayende, maybe an update to NHProf could hint them about this setting.)