Fix regression caused by logging refactoring. #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lnu could you please check that it fixes your problem? |
| NHibernateLogger.SetLoggersFactory(default(INHibernateLoggerFactory)); | ||
|
|
||
| // NoLoggingNHibernateLogger is internal | ||
| Assert.That(LoggerProvider.LoggerFor("pizza"), Is.InstanceOf<NoLoggingInternalLogger>()); |
There was a problem hiding this comment.
Irrelevant comment. And next one too.
src/NHibernate/Logging.cs
Outdated
| @@ -52,6 +52,10 @@ public static class NHibernateLogger | |||
| private const string nhibernateLoggerConfKey = "nhibernate-logger"; | |||
| private static INHibernateLoggerFactory _loggerFactory; | |||
|
|
|||
| #pragma warning disable 618 | |||
| internal static ILoggerFactory LegacyLoggerFactory { private set; get; } | |||
There was a problem hiding this comment.
A bit strange to see the setter before the getter. I would rather have it in the usual order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back the unit tests for the legacy logging provider obsoleted by #1377.
Fixes #1478.