Fix exceptions serialization #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
previously approved these changes
Jan 6, 2018
| var typeName = entry.Value?.ToString(); | ||
| if (!string.IsNullOrEmpty(typeName)) | ||
| TargetType = System.Type.GetType(typeName, true); | ||
| } |
There was a problem hiding this comment.
When having many values, a switch seems more appropriate.
switch (entry.Name)
{
case "PropertyName":
PropertyName = entry.Value?.ToString();
break;
case "AccessorType":
AccessorType= entry.Value?.ToString();
break;
case "TargetType":
var typeName = entry.Value?.ToString();
if (!string.IsNullOrEmpty(typeName))
TargetType = System.Type.GetType(typeName, true);
break;
}(DuplicateMappingException and LazyInitializationException have two values, others only one.)
There was a problem hiding this comment.
I did consider this option and even written it this way at first, but for some reasons decided against it. The underlying byte-code would be the same anyway.
| @@ -16,7 +18,7 @@ public SchemaValidationException(string msg, IList<string> validationErrors) : b | |||
|
|
|||
| protected SchemaValidationException(SerializationInfo info, StreamingContext context) : base(info, context) | |||
| { | |||
| ValidationErrors = | |||
| ValidationErrors = | |||
| (ReadOnlyCollection<string>) info.GetValue("ValidationErrors", typeof(ReadOnlyCollection<string>)); | |||
hazzik
force-pushed
the
exceptions-serialization-fixes
branch
from
37aefbd to
db61060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial rework of #1469 in a non-breaking way concerning only exceptions.