Deep removal of Fetch result operators when Any is used #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
previously approved these changes
Jan 26, 2018
| @@ -36,10 +36,9 @@ public override void VisitResultOperator(ResultOperatorBase resultOperator, Quer | |||
| } | |||
| if (resultOperator is AnyResultOperator) | |||
| { | |||
| Array.ForEach(queryModel.ResultOperators.OfType<FetchOneRequest>().ToArray(), op => queryModel.ResultOperators.Remove(op)); | |||
| Array.ForEach(queryModel.ResultOperators.OfType<FetchManyRequest>().ToArray(), op => queryModel.ResultOperators.Remove(op)); | |||
| ResultOperatorRemover.Remove(queryModel, x=>x is FetchRequestBase); | |||
There was a problem hiding this comment.
Lacking spaces around =>. This may cause unrelated changes later on when working again on that code.
hazzik
approved these changes
Jan 29, 2018
|
The tests wasn't regenerated |
fredericDelaporte
added a commit
to fredericDelaporte/nhibernate-core
that referenced
this pull request
Jan 31, 2018
fredericDelaporte
added a commit
that referenced
this pull request
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already partially fixed in #140 , but failed when a Fetch was used in a subquery.