Move MsSql constants from driver to dialect. #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spaces to tabs. Use static private methods where possible.
fredericDelaporte
approved these changes
Mar 13, 2018
I don't understand what is the point of doing this. |
|
It is required for providing the driver as a separated project, which should be done for allowing people to not rely on reflection under .Net Core/Standard if they wish. (Unless it is considered as something to be supplied externally, but I am not agree with such a view. Supplying drivers with explicit dependencies for most common databases should be done by an ORM in my opinion.) |
hazzik
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split off from #626 just incase I don't get that fully rebased in time for v5.1. These changes are still valuable, but easy to review.
Also: