Release 5.1.2 #1664
Release 5.1.2 #1664
Conversation
fredericDelaporte
force-pushed
the
Release5.1.2
branch
from
9ce3e53 to
2094609
Compare
|
Rebased and 5.1.2 release notes updated with latest change. |
fredericDelaporte
force-pushed
the
Release5.1.2
branch
from
2094609 to
a1073d6
Compare
|
Rebased again, line for #1670 added in release notes. I think I will release this soon (maybe tomorrow). |
|
Ok. |
|
AppVeyor build is quite flaky. This is annoying. Anyway, I now consider fixing #1667 in 5.1.x, if it is considered a thing to fix in NHibernate (which would be safer). |
Go for it. |
fredericDelaporte
force-pushed
the
Release5.1.2
branch
2 times, most recently
from
8137d95 to
a150861
Compare
|
Of course. That is in the release procedure anyway. |
And add a missing 5.0.0 possible breaking change, see nhibernate#1663.
To be squashed.
fredericDelaporte
force-pushed
the
Release5.1.2
branch
from
a150861 to
1c1549f
Compare
|
Notes updated and branch rebased. (Contrary to the Release5.0.6 branch, which was not up-to-date and which build must not be used for the release. I am waiting the 5.0.x release build. Anyway, we are supposed to published from base branch builds rather than from PR branch builds.) |
|
Do you plan to merge 5.0.6 to 5.1.x? Or are you willing to let them diverge? |
|
That would be a "no-op" merge. I think that when we have started back-porting instead of fixing in the older branch then merging to newer branches, we should let the older branch diverge. This is why I have manually ported here the 5.0.6 release notes changes. But if you rather not have any current major branches diverging, we can still merge it back to 5.1.x before releasing 5.1.2, even if this will somewhat pollute the history. (In such case we should avoid back-porting to 5.0.x but instead fix there then merge to newer branches.) |
|
I'm ok with diverging. |
And add a missing 5.0.0 possible breaking change, see #1663.
The GitHub 5.0.0 release is not yet updated with that missing possible breaking change, I will do that once this PR is approved. (Update: now done.)
I am already preparing this release just for not forgetting about adding that possible breaking change.