Unit test & Fix for GH1704 #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Country = country; | ||
| } | ||
| public virtual string Country { get; set; } | ||
| public virtual string City { get; set; } |
There was a problem hiding this comment.
White-spaces mixup. Sorry but NHibernate uses tabs, please reformat.
| @@ -55,6 +55,9 @@ protected override Expression VisitNew(NewExpression expression) | |||
| { | |||
| _transformed = true; | |||
| // Transform each initializer recursively (to allow for nested initializers) | |||
| if(expression.Members == null) | |||
There was a problem hiding this comment.
Missing space before the opening parenthesis.
| namespace NHibernate.Test.NHSpecificTest.GH1704 | ||
| { | ||
| [TestFixture] | ||
| public class Fixture : BugTestCase |
There was a problem hiding this comment.
Due to the test nature, it appears to me no async code re-generation has been run, because for such a test, it should have generated an async counterpart. Please run the async generator. (See contributing.)
fredericDelaporte
approved these changes
May 23, 2018
|
Thanks for your contribution. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggested fix for #1704