Release 5.1.3 #1716
Merged
Release 5.1.3 #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
approved these changes
May 31, 2018
It could have been, but now that it is merged on master, and since this is not a regression, I think it can stay in 5.2. Otherwise it would need to be backported via an additional PR cherry-picking the change from master. Then it may cause some additional conflicts on merging (there will be other conflicts, on the proxy stuff at least), but also it will cause some noise in the release notes, having a subject twice fixed, once in 5.1.3 and once in 5.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the release.
I intend to wait until 5.1.2 is at least one month old (so until June, 10th), or until we have some critical fix to do.