Reconnect lazy property proxy on deserialization #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Reconnect the lazy property proxies | ||
| foreach (var p in entitiesByKey) | ||
| { | ||
| if (p.Value is IFieldInterceptorAccessor lazyPropertyProxy && lazyPropertyProxy.FieldInterceptor != null) |
There was a problem hiding this comment.
AbstractEntityPersister.AfterReassociate does also this kind of things, but it is meant for detached entities and also handle dirtiness, which should be left untouched in the session deserialization case.
fredericDelaporte
force-pushed
the
LazyProxyDeserialization
branch
from
7323ddf to
3a795fe
Compare
hazzik
reviewed
Jun 11, 2018
| Text = "Text1" | ||
| }; | ||
| s.Save(se); | ||
| _idSimpleEntity1 = se.Id; |
There was a problem hiding this comment.
Better to write _idSimpleEntity1 = (Guid)s.Save(se);. You can declare the _idSimpleEntity1 field as object and drop casting as the concrete type of the key does not matter.
There was a problem hiding this comment.
This looks to me as quite a matter of taste. I rather have two lines of code rather than a hard-coded cast. Granted, the test case does not need the exact typing of the id.
To be squashed.
hazzik
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deserializing a session holding entities with uninitialized lazy properties, the lazy properties cannot be accessed because their proxy does no more have a session.
This is an old issue, independent of the used proxy factory. (Provided it is considered that proxies should not serialize their session, in order to avoid serializing the whole session when just serializing one entity.)