Skip to content

Delay entity insert on Persist until session is flushed #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 28, 2018
Merged

Delay entity insert on Persist until session is flushed #1754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9d910cd
Add failing tests
hazzik Jun 16, 2018
efb5284
Revert previous behaviour
hazzik Jun 17, 2018
48ee983
Set shouldDelayIdentityInserts = !requiresImmediateIdAccess
hazzik Oct 30, 2018
a759f83
Update xml comment outdated by the PR
fredericDelaporte Nov 14, 2018
1f3f430
Port HHH-12826 and HHH-12846.
fredericDelaporte Nov 14, 2018
611c583
Fix Firebird failure
fredericDelaporte Nov 14, 2018
4497aff
Do a better fix than HHH-12826
fredericDelaporte Nov 14, 2018
256c1da
Remove unused finalKey field from CollectionAction
hazzik Nov 14, 2018
8858389
Temporary comment out resolving delayed key in AfterAction
hazzik Dec 26, 2018
1e6ca03
Fix compilation
hazzik Dec 26, 2018
d9f3d17
Set CurrentKey of CollectionEntry prior AfterAction
hazzik Dec 26, 2018
512cbd4
Temporary comment out setting CurrentKey before AfterAction
hazzik Dec 26, 2018
7c840a6
Add tests for ownership changes
fredericDelaporte Dec 28, 2018
2a7906c
Remove unneeded code and add some comments
fredericDelaporte Dec 28, 2018
c455f86
Merge branch 'master' into mpga
fredericDelaporte Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
463 changes: 463 additions & 0 deletions src/NHibernate.Test/Async/NHSpecificTest/GH1754/Fixture.cs
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 25 additions & 0 deletions src/NHibernate.Test/NHSpecificTest/GH1754/Entity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
using System;
using System.Collections.Generic;

namespace NHibernate.Test.NHSpecificTest.GH1754
{
public class Entity
{
public virtual int Id { get; set; }
public virtual string Name { get; set; }
public virtual ISet<ChildEntity> Children { get; set; } = new HashSet<ChildEntity>();
}

public class EntityWithoutDeleteOrphan
{
public virtual int Id { get; set; }
public virtual string Name { get; set; }
public virtual ISet<ChildEntity> Children { get; set; } = new HashSet<ChildEntity>();
}

public class ChildEntity
{
public virtual Guid Id { get; set; }
public virtual string Name { get; set; }
}
}
Loading