Skip to content

Support multiple formulas on one-to-one #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

fredericDelaporte
Copy link
Member

Hbm supports multiple formulas on one-to-one, but mapping by code does not allow specifying them on one-to-one.
(It does neither on any other elements, but #1759 will fix that for the other elements by adding a ColumnsAndFormulas method.)


// 6.0 TODO: move method into IOneToOneMapper
public static class OneToOneMapperExtension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensions please

@hazzik
Copy link
Member

hazzik commented Jun 21, 2018

Why only one-to-one? Others lack of these methods too.

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Jun 21, 2018

With #1759, others will have ColumnsAndFormulas for doing this. Adding Formulas would be just some added convenience, while there is already quite many methods on these interfaces. So I have not considered adding it on others.

If willing them, I would have better adding them through #1759, since it defines a common interface for all the other cases, in which I could add it.

To be squashed.
@fredericDelaporte
Copy link
Member Author

Replaced by #1759

@fredericDelaporte fredericDelaporte deleted the OneToOneFormulas branch June 23, 2018 10:36
@fredericDelaporte fredericDelaporte removed this from the 5.2 milestone Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants