Allow to use dynamic objects as dynamic components #1778

hazzik · 2018-06-28T03:28:30Z

Sorry for the tautology

fredericDelaporte · 2018-06-28T15:20:34Z

Commit added for updating the documentation.

hazzik · 2018-06-28T23:04:04Z

src/NHibernate.Test/NHibernate.Test.csproj

@@ -48,7 +48,7 @@
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="log4net" Version="2.0.8" />
-    <PackageReference Include="System.Linq.Dynamic.Core" Version="1.0.8" />
+    <PackageReference Include="System.Linq.Dynamic.Core" Version="1.0.8.11" />


The 1.0.8 version did not work on mono/.NET Core due to this bug: zzzprojects/System.Linq.Dynamic.Core#157. So updated to latest.

hazzik · 2018-06-28T23:34:37Z

src/NHibernate/Linq/Visitors/HqlGeneratorExpressionVisitor.cs

@@ -206,6 +222,18 @@ private HqlTreeNode VisitNhNominated(NhNominatedExpression nhNominatedExpression

 		private HqlTreeNode VisitInvocationExpression(InvocationExpression expression)
 		{
+			//This is an ugly workaround for dynamic expressions.


In .NET Core/Mono the DynamicExpression is "reduced" to a CallSite delegate call, but on full .NET it does not happen.

hazzik · 2018-06-29T01:52:21Z

Regardless of the views on relations with dynamic-entity vs dynamic-component can we agree to move with the different PRs for them?

fredericDelaporte

Squashed.

hazzik · 2018-06-30T01:43:38Z

I wonder. The System.Linq.Dynamic.Core supports only GetMemberBinder. Do we need to care about other binder types?

fredericDelaporte · 2018-06-30T10:31:07Z

I am not knowledgeable enough in that area for telling. Would it allow to better support querying a component sub-collection? (I mean, if a dynamic component owns a collection, currently trying to apply to it an .Any condition will fail, the dynamic expression engine being not able to recognize it as a collection.)

hazzik · 2018-07-03T05:25:17Z

Would it allow to better support querying a component sub-collection?

Unlikely

if a dynamic component owns a collection, currently trying to apply to it an .Any condition will fail, the dynamic expression engine being not able to recognize it as a collection.

Any is an extension method. Dynamic objects do not support extension methods OOB. And System.Linq.Dynamic does not have a logic to handle such a situation.

However, this would probably work now:

customers.Where("Enumerable.Any(Phones, p=>p.Number = @0)", "1234");

fredericDelaporte · 2018-07-03T10:18:35Z

I wonder. The System.Linq.Dynamic.Core supports only GetMemberBinder. Do we need to care about other binder types?

I have taken a look at it. The other types are GetIndexBinder, SetMemberBinder and SetIndexBinder, right?

Supporting GetIndexBinder should allow to support dictionary syntax in dynamic Linq. Why not but I do not see much value in it. The dictionary syntax is quite ugly. Maybe we should even obsolete it, now that dynamic is supported.

About the setters, maybe it could make sense to support them for NHibernate linq update and insert extensions. But since they already supports anonymous objects, I do not think we really need to do that.

Update: and there are also DeleteMemberBinder, DeleteIndexBinder and InvokeMemberBinder. The two formers, I do not see in which case supporting them could be useful. The later could maybe allow to support the Any case.

hazzik · 2018-07-03T10:50:53Z

I have taken a look at it. The other types are GetIndexBinder, SetMemberBinder and SetIndexBinder, right?

Yes, these are the ones which potentially interest us. Others are not so interested.

The later could maybe allow to support the Any case.

Again, this is not supported by the "dynamic" provider.

Also, I could not find any provider which does support/use System.Linq.Expressions.DynamicExpression "in the wild" (except the System.Linq.Dynamic.Core which has very limited use of it and only emits GetMemberBinder).

We could write tests which construct the desired expressions and add support for them, but do we want to do this?

fredericDelaporte · 2018-07-03T11:16:48Z

Without concrete use cases, no.

hazzik · 2018-07-04T13:21:26Z

Just force-pushed to be inline with the master. No changes.

hazzik · 2018-07-19T12:19:34Z

Related #947

fredericDelaporte · 2018-09-16T10:21:06Z

Any reason for not merging this?

hazzik · 2018-09-16T10:23:54Z

I wanted to keep these as 2 commits, which will require to rebase on master once again. But I never got time to finish.

fredericDelaporte · 2018-09-16T13:11:00Z

I have locally checked the rebase, no trouble, no conflict to resolve. It also seems the two commits of this PR could be directly merged (with merge commit) without a rebase. Maybe were you thinking about #1452, on which I have the same question, and that I consider merging very soon.

fredericDelaporte

Rebased.

hazzik · 2018-10-30T21:15:50Z

Rebased with fix.

hazzik · 2018-10-30T21:37:07Z

I intend to merge it as soon as test pass, please do not merge anything to master before this PR is merged.

hazzik force-pushed the dynamic-component branch from f650789 to 34c0693 Compare June 28, 2018 03:37

hazzik changed the title ~~Allow dynamic in dynamic component~~ Allow to use dynamic objects as dynamic components Jun 28, 2018

hazzik added t: Improvement c: Core p: Minor labels Jun 28, 2018

hazzik added this to the 5.2 milestone Jun 28, 2018

hazzik force-pushed the dynamic-component branch 3 times, most recently from d2ad250 to 5f1bf8d Compare June 28, 2018 05:23

This comment has been minimized.

Sign in to view

fredericDelaporte mentioned this pull request Jun 28, 2018

Add ability to use dynamic entities as C# dynamic hazzik/nhibernate-core#7

Closed

This comment has been minimized.

Sign in to view

hazzik commented Jun 28, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

hazzik commented Jun 28, 2018

View reviewed changes

nhibernate deleted a comment from fredericDelaporte Jun 29, 2018

fredericDelaporte previously approved these changes Jun 29, 2018

View reviewed changes

fredericDelaporte dismissed their stale review via dd0debd June 29, 2018 13:20

fredericDelaporte force-pushed the dynamic-component branch from 0cf80d9 to dd0debd Compare June 29, 2018 13:20

fredericDelaporte previously approved these changes Jun 29, 2018

View reviewed changes

hazzik dismissed fredericDelaporte’s stale review via 7349d19 July 4, 2018 13:14

hazzik force-pushed the dynamic-component branch from dd0debd to 7349d19 Compare July 4, 2018 13:14

fredericDelaporte previously approved these changes Jul 4, 2018

View reviewed changes

fredericDelaporte dismissed their stale review via 92ce88a October 30, 2018 12:48

fredericDelaporte force-pushed the dynamic-component branch from 7349d19 to 92ce88a Compare October 30, 2018 12:48

fredericDelaporte previously approved these changes Oct 30, 2018

View reviewed changes

hazzik added 2 commits October 31, 2018 10:15

Add support for querying dynamic objects with Linq

128e336

Add ability to use dynamic component in any format

5df1fde

hazzik dismissed fredericDelaporte’s stale review via 5df1fde October 30, 2018 21:15

hazzik force-pushed the dynamic-component branch from 92ce88a to 5df1fde Compare October 30, 2018 21:15

hazzik merged commit 52a4bd4 into nhibernate:master Oct 30, 2018

hazzik added the r: Fixed label Oct 30, 2018

fredericDelaporte mentioned this pull request Nov 8, 2018

Add ability to use dynamic entities as C# dynamic #1901

Merged

This comment has been minimized.

Sign in to view

hazzik deleted the dynamic-component branch March 15, 2019 01:39

Allow to use dynamic objects as dynamic components #1778

Allow to use dynamic objects as dynamic components #1778

Uh oh!

Conversation

hazzik commented Jun 28, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

fredericDelaporte commented Jun 28, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

hazzik Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hazzik Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

hazzik commented Jun 29, 2018

Uh oh!

fredericDelaporte left a comment

Choose a reason for hiding this comment

Uh oh!

hazzik commented Jun 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte commented Jun 30, 2018

Uh oh!

hazzik commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte commented Jul 3, 2018 • edited by hazzik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazzik commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte commented Jul 3, 2018

Uh oh!

hazzik commented Jul 4, 2018

Uh oh!

hazzik commented Jul 19, 2018

Uh oh!

fredericDelaporte commented Sep 16, 2018

Uh oh!

hazzik commented Sep 16, 2018

Uh oh!

fredericDelaporte commented Sep 16, 2018

Uh oh!

fredericDelaporte left a comment

Choose a reason for hiding this comment

Uh oh!

hazzik commented Oct 30, 2018

Uh oh!

hazzik commented Oct 30, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

hazzik commented Jun 30, 2018 •

edited

Loading

hazzik commented Jul 3, 2018 •

edited

Loading

fredericDelaporte commented Jul 3, 2018 •

edited by hazzik

Loading

hazzik commented Jul 3, 2018 •

edited

Loading