Skip to content

Release 5.2.0 #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Sep 30, 2018

Preparing the release.

I have already moved issues in the 5.2 milestone to a 5.3 milestone when they were non closed and without any pending PR.

16 PR are awaiting in the 5.2 milestone. Some are WIP or looks like, others are pending approval.

@fredericDelaporte fredericDelaporte added this to the 5.2 milestone Sep 30, 2018
@fredericDelaporte fredericDelaporte force-pushed the v5.2.0 branch 2 times, most recently from e1d1616 to f6614fe Compare October 4, 2018 21:43
@gliljas gliljas self-assigned this Oct 5, 2018
@gliljas gliljas self-requested a review October 5, 2018 20:04
@gliljas gliljas removed their assignment Oct 5, 2018
gliljas
gliljas previously approved these changes Oct 5, 2018
Copy link
Member

@gliljas gliljas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid

@fredericDelaporte
Copy link
Member Author

Fifteen PR remain in the milestone. We have to decide whether to leave them out or finish them. Most of them are awaiting validation and may not require additional work.

@fredericDelaporte fredericDelaporte force-pushed the v5.2.0 branch 5 times, most recently from 47e47ec to 7241951 Compare November 19, 2018 12:20
@hazzik
Copy link
Member

hazzik commented Nov 20, 2018

@fredericDelaporte can we hold-on the release till end of this week? I want try to finish some WIP tasks.

@fredericDelaporte
Copy link
Member Author

No troubles, I was not intending to rush it anyway.

@fredericDelaporte
Copy link
Member Author

Rebased, and release notes are up-to-date.

hazzik
hazzik previously approved these changes Dec 2, 2018
@fredericDelaporte
Copy link
Member Author

I forgot to update the issue count from 156 to 157 in the release notes. Now it is done.

@fredericDelaporte fredericDelaporte merged commit fdac0d0 into nhibernate:master Dec 3, 2018
@fredericDelaporte fredericDelaporte deleted the v5.2.0 branch December 3, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants