Replace an O(n) lookup in LINQ query parsing by an O(1) one #1869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
previously approved these changes
Oct 7, 2018
The HQL generators registry already uses dictionaries to resolve generators for methods found in LINQ expression. But some generators do not declare statically their supported methods and instead have to be queried with a loop on them for support of methods encountered in the LINQ query. The result of this lookup can be cached for avoiding calling this loop again on the next query using the method. If nhibernate#1868 is merged, this change will compensate for nhibernate#1868 causing up to three such lookups by method.
fredericDelaporte
force-pushed
the
CacheRuntimeGenerator
branch
from
e401cd1 to
cdd8e2c
Compare
|
I have included the missing async trivial regen from another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HQL generators registry already uses dictionaries to resolve generators for methods found in LINQ expression. But some generators do not declare statically their supported methods and instead have
to be queried with a loop on them for support of methods encountered in the LINQ query.
The result of this lookup can be cached for avoiding calling this loop again on the next query using the method.
If #1868 is merged, this change will compensate for #1868 causing up to three such lookups by method.