Property-ref on many-to-one with composite id fails #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/NHibernate.Test/NHSpecificTest/EmbIdBidirectional/BiEmbIdRefEdEntity.cs
Outdated
Show resolved
Hide resolved
src/NHibernate.Test/NHSpecificTest/EmbIdBidirectional/Fixture.cs
Outdated
Show resolved
Hide resolved
src/NHibernate.Test/NHSpecificTest/EmbIdBidirectional/Fixture.cs
Outdated
Show resolved
Hide resolved
src/NHibernate.Test/NHSpecificTest/EmbIdBidirectional/Fixture.cs
Outdated
Show resolved
Hide resolved
|
It is likely to be caused by #1872. |
|
#1872 has introduced a call to //note that this implementation is kinda broken
//for components with many-to-one associations
return ResolveIdentifier(value, session, owner);It does not tell what is the trouble, but maybe that is what causes the failure here and has to be fixed. I am checking this. |
|
I have pushed the reviewed changes, and I have added a fix. |
hazzik
reviewed
Dec 3, 2018
fredericDelaporte
changed the title
|
I have updated the title and description for more closely matching the actual issue. This issue is not specific to one-to-one. |
hazzik
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHibernate fails loading an entity when it has a many-to-one which use a composite-id foreign key and is referenced by a property-ref.
Regression bug. Didn't exist in 5.1.x.
Found it when I upgrading Envers project to use NH Core 5.2 => similar test fails there as well now.