Skip to content

Cease having dynamic composite-id causing swallowed exceptions #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2018
Merged

Cease having dynamic composite-id causing swallowed exceptions #1938

merged 2 commits into from
Dec 19, 2018

Conversation

RogerKratz
Copy link
Contributor

@RogerKratz RogerKratz commented Dec 17, 2018 •
edited by fredericDelaporte
Loading

Fixes #1047

@RogerKratz RogerKratz mentioned this pull request Dec 17, 2018
Closed
@fredericDelaporte
Remove an undue handling by exception
dbea7bb 
And reformat test and generate async code for test
@fredericDelaporte fredericDelaporte changed the title Example code for NH-3865 Fix undue handling by exception Dec 18, 2018
fredericDelaporte
fredericDelaporte reviewed Dec 18, 2018
View reviewed changes
@fredericDelaporte fredericDelaporte added this to the 5.3 milestone Dec 18, 2018
hazzik
hazzik approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@hazzik hazzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have more descriptive title?

@fredericDelaporte fredericDelaporte changed the title Fix undue handling by exception Cease having dynamic composite-id causing swallowed exceptions Dec 18, 2018
@fredericDelaporte
Copy link
Member

I have no better idea than this new one.

@hazzik
Copy link
Member

hazzik commented Dec 18, 2018

This one is better. Thanks.

@fredericDelaporte fredericDelaporte merged commit e313b07 into nhibernate:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte left review comments

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@RogerKratz @fredericDelaporte @hazzik