Skip to content

Do missing async generation for cache batch optimization #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Do missing async generation for cache batch optimization #2063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NHibernate/Async/Event/Default/DefaultInitializeCollectionEventListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ private async Task<bool> InitializeCollectionFromCacheAsync(
CollectionEntry[] collectionEntries = null;
var collectionBatch = source.PersistenceContext.BatchFetchQueue.QueryCacheQueue
?.GetCollectionBatch(persister, collectionKey, out collectionEntries);
if ((collectionBatch != null || batchSize > 1) && persister.Cache.PreferMultipleGet())
if (collectionBatch != null || batchSize > 1 && persister.Cache.PreferMultipleGet())
{
// The first item in the array is the item that we want to load
if (collectionBatch != null)
Expand Down
2 changes: 1 addition & 1 deletion src/NHibernate/Async/Event/Default/DefaultLoadEventListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ protected virtual async Task<object> LoadFromSecondLevelCacheAsync(LoadEvent @ev
var batchSize = persister.GetBatchSize();
var entityBatch = source.PersistenceContext.BatchFetchQueue.QueryCacheQueue
?.GetEntityBatch(persister, @event.EntityId);
if ((entityBatch != null || batchSize > 1) && persister.Cache.PreferMultipleGet())
if (entityBatch != null || batchSize > 1 && persister.Cache.PreferMultipleGet())
{
// The first item in the array is the item that we want to load
if (entityBatch != null)
Expand Down