Add missing sqlite.binaryguid to configuration schema #2245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
approved these changes
Oct 13, 2019
fredericDelaporte
added a commit
to fredericDelaporte/nhibernate-core
that referenced
this pull request
Jan 12, 2020
(cherry picked from commit 23df8cd)
fredericDelaporte
added a commit
that referenced
this pull request
Jan 12, 2020
(cherry picked from commit 23df8cd)
hazzik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here, a new setting added in 5.2.x is lacking its declaration in the configuration xsd, causing it to be unusable inside the configuration file.
Ideally this should be fixed in 5.2.x, but I do not think it is worth a 5.2.x release on its own. So unless we have another 5.2.x to do before releasing 5.3, I am in favor of merging this into 5.3.