Add missing options to QueryOver #2275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
reviewed
Nov 24, 2019
bahusoid
reviewed
Nov 24, 2019
hazzik
previously approved these changes
Nov 27, 2019
bahusoid
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2270
Fix it by adding the missing options as extension methods, rather than documenting getting them through the underlying criteria. If that is accepted, then #2270 should be rewritten a bit.
Adds
SetTimeout,SetFetchSize,SetComment.It seems the
IQueryOverinterface tends to drop theSetprefix. Should theses extension methods do the same? It does not look to me as a proper convention, since methods are supposed to start with a verb. But if it is preferred to keep dropping the verb for the interface consistency, I will do.