Support setting parameters with a dynamic object #2320
Conversation
fredericDelaporte
force-pushed
the
SetParametersFromDictionary
branch
from
3017c72 to
097aad5
Compare
| @@ -651,6 +651,8 @@ public IQuery SetEnum(string name, Enum val) | |||
| return this; | |||
| } | |||
|
|
|||
| // Since 5.3 | |||
| [Obsolete("This method was never surfaced to a query interface. Use the overload or extension method taking a generic dictionary instead.")] | |||
| public IQuery SetProperties(IDictionary map) | |||
There was a problem hiding this comment.
I have considered adding an extension method for it too, but this was causing an ambiguous method call when using a Dictionary<string, object>, since it does implement both IDictionary and IDictionary<string, object>. So it looks to me not worth keeping this method.
| /// </summary> | ||
| /// <param name="query">The query on which to set the parameters.</param> | ||
| /// <param name="map">A dictionary of parameters values by names.</param> | ||
| public static IQuery SetParameters(this IQuery query, IDictionary<string, object> map) |
There was a problem hiding this comment.
I had to change the name, since non extension methods takes precedence. Moreover the name SetProperties does not make much sense in my view, this one is more semantically accurate I think.
So I have added a commit to obsolete SetProperties in favor of a SetParameters overload.
| } | ||
|
|
||
| // Since 5.3 | ||
| [Obsolete("Use SetParameters method instead.")] | ||
| public IQuery SetProperties(object bean) |
There was a problem hiding this comment.
What if we use this method to support the IDictionary<string, object>?
| public IQuery SetProperties(object bean) | |
| public IQuery SetProperties(object bean) | |
| { | |
| if (bean is IDictionary<string, object> map) | |
| { | |
| // TODO: | |
| } | |
| } |
There was a problem hiding this comment.
It would be less discoverable, but it would support dynamic without having to do an explicit static call on some extension class.
Fixes #2009