Add an option to register a custom pre-transformer for a Linq query #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
added
c: Linq Provider
p: Minor
t: New Feature
and removed
t: Fix
labels
fredericDelaporte
previously approved these changes
Jun 7, 2020
There was a problem hiding this comment.
This is not a fix for #725, but a new feature allowing users to fix #725 by themselves. The description of this PR should be updated accordingly.
I do not think this PR should directly close #725. We should close it as a kind of "won't fix", with instructions on how to change the behavior, likely just copying your test case example.
I agree, description updated. |
hazzik
reviewed
Jun 10, 2020
src/NHibernate/Linq/Visitors/IExpressionTransformerInitializer.cs
Outdated
Show resolved
Hide resolved
bahusoid
reviewed
Jun 10, 2020
fredericDelaporte
approved these changes
Jun 14, 2020
hazzik
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to rewrite the linq expression before the extraction of query parameters, which allows the user to achieve the behavior requested in #725 (test provided) by modifying the parameter values.