Skip to content

Fix iconUrl warning #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2020
Merged

Fix iconUrl warning #2435

merged 1 commit into from
Jul 20, 2020

Conversation

fredericDelaporte
Copy link
Member

Fix the iconUrl warning occurring on NuGet push.
See https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packageiconurl

@fredericDelaporte fredericDelaporte added this to the 5.3.1 milestone Jul 19, 2020
@hazzik hazzik merged commit a10ba17 into nhibernate:5.3.x Jul 20, 2020
@hazzik
Copy link
Member

hazzik commented Jul 20, 2020

Oops. Should have gone to master.

@fredericDelaporte
Copy link
Member Author

It was intended to target 5.3.x.
I expect we will have some fixes to do, and then it will be merged to master once 5.3.1 will be released.

@fredericDelaporte fredericDelaporte deleted the iconUrl branch July 20, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: Toolset p: Lowest r: Fixed t: Task
Projects
None yet
Milestone
5.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericDelaporte @hazzik