Skip to content

Fix detecting parameter types in subqueries for Linq provider #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions src/NHibernate.Test/Linq/ParameterTypeLocatorTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,51 @@ public void EqualStringEnumTest()
);
}

[Test]
public void EqualStringEnumTestWithFetch()
{
AssertResults(
new Dictionary<string, Predicate<IType>>
{
{"3", o => o is EnumStoredAsStringType}
},
db.Users.Fetch(o => o.Role).ThenFetch(o => o.ParentRole).Where(o => o.Enum1 == EnumStoredAsString.Large),
db.Users.Fetch(o => o.Role).ThenFetch(o => o.ParentRole).Where(o => EnumStoredAsString.Large == o.Enum1),
db.Timesheets.SelectMany(o => o.Users).Fetch(o => o.Role).Where(o => EnumStoredAsString.Large == o.Enum1),
db.Timesheets.FetchMany(o => o.Users).SelectMany(o => o.Users).Where(o => EnumStoredAsString.Large == o.Enum1),
db.Timesheets.FetchMany(o => o.Users).Where(o => o.Users.Any(u => EnumStoredAsString.Large == u.Enum1))
);
}

[Test]
public void EqualStringEnumTestWithSubQuery()
{
AssertResults(
new Dictionary<string, Predicate<IType>>
{
{"3", o => o is EnumStoredAsStringType}
},
db.Users.Where(o => db.Users.Any(u => u.Enum1 == EnumStoredAsString.Large)),
db.Users.Where(o => db.Users.Any(u => EnumStoredAsString.Large == u.Enum1)),
db.Timesheets.Where(o => o.Users.Any(u => EnumStoredAsString.Large == u.Enum1))
);
}

[Test]
public void EqualStringEnumTestWithMaxSubQuery()
{
AssertResults(
new Dictionary<string, Predicate<IType>>
{
{"3", o => o is EnumStoredAsStringType}
},
db.Users.Fetch(o => o.Role).Where(o => db.Users.Max(u => u.Enum1 == EnumStoredAsString.Large ? u.Id : -u.Id) == o.Id),
db.Users.Fetch(o => o.Role).Where(o => db.Users.Max(u => EnumStoredAsString.Large == u.Enum1 ? u.Id : -u.Id) == o.Id),
db.Users.Where(o => db.Users.Max(u => u.Enum1 == EnumStoredAsString.Large ? u.Id : -u.Id) == o.Id),
db.Users.Where(o => db.Users.Max(u => EnumStoredAsString.Large == u.Enum1 ? u.Id : -u.Id) == o.Id)
);
}

[Test]
public void EqualStringTest()
{
Expand Down
6 changes: 6 additions & 0 deletions src/NHibernate/Util/ExpressionsHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,12 @@ protected override Expression VisitQuerySourceReference(QuerySourceReferenceExpr
return node;
}

protected override Expression VisitSubQuery(SubQueryExpression expression)
{
base.Visit(expression.QueryModel.SelectClause.Selector);
return expression;
}

protected override Expression VisitUnary(UnaryExpression node)
{
// Store only the outermost cast, when there are multiple casts for the same member
Expand Down