Skip to content

Fix entity join for entity with discriminator #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Fix entity join for entity with discriminator #2464

merged 1 commit into from
Jul 30, 2020

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Jul 29, 2020 •
edited
Loading

Fixes #2463

I wonder why it's still not fixed in hibernate. They seem behave the same - discriminator replaces text node and then used for persister retrieval

@bahusoid bahusoid changed the base branch from master to 5.3.x July 29, 2020 23:53
@fredericDelaporte
Copy link
Member

Is this a 5.3 regression? Or an older one? #2463 does not tell in which version it was working, and no one has confirmed this was a regression.

@bahusoid
Copy link
Member Author

bahusoid commented Jul 30, 2020 •
edited
Loading

Yes it's 5.3 regression. Entity Join is implemented in 5.3

@fredericDelaporte fredericDelaporte added this to the 5.3.2 milestone Jul 30, 2020
@hazzik hazzik merged commit e72daa0 into nhibernate:5.3.x Jul 30, 2020
@hazzik hazzik mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3.2
Development

Successfully merging this pull request may close these issues.

Path expected for join
3 participants
@bahusoid @fredericDelaporte @hazzik