Skip to content

Fix ExtractInterceptor for subclasses #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2020
Merged

Fix ExtractInterceptor for subclasses #2509

merged 5 commits into from
Sep 2, 2020

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Sep 1, 2020

Fix for a regression made by #1946.

Fixes #2508

bahusoid
bahusoid reviewed Sep 1, 2020
View reviewed changes
@bahusoid
Copy link
Member

bahusoid commented Sep 1, 2020 •
edited
Loading

What about check inside InjectInterceptor:

nhibernate-core/src/NHibernate/Tuple/Entity/BytecodeEnhancementMetadataPocoImpl.cs

Line 135 in 9fc784e

if (entity.GetType().BaseType != _entityType)

Shouldn't it be _entityType.IsInstanceOf(entity)?

@maca88
Copy link
Contributor Author

maca88 commented Sep 1, 2020

Shouldn't it be _entityType.IsInstanceOf(entity)?

Good observation, yes it should. Changed.

bahusoid
bahusoid reviewed Sep 2, 2020
View reviewed changes
hazzik
hazzik reviewed Sep 2, 2020
View reviewed changes
@bahusoid bahusoid added this to the 5.3.3 milestone Sep 2, 2020
@hazzik hazzik merged commit 1581887 into nhibernate:5.3.x Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahusoid bahusoid bahusoid approved these changes

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@maca88 @bahusoid @hazzik