Add special case for constants contained within Convert nodes (#2642) #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkreipke thanks for the PR, I added a small optimization and some additional tests. |
maca88
reviewed
Feb 3, 2021
| // because it might be necessary if the types are incompatible with each other, which might happen if | ||
| // the expression uses an implicitly or explicitly defined cast operator. | ||
| if (node.NodeType == ExpressionType.Convert && | ||
| node.Method != null && // The implicit/explicit operator method |
There was a problem hiding this comment.
Avoid compiling and evaluating the value for .NET built-in conversions.
fredericDelaporte
approved these changes
Feb 6, 2021
bahusoid
pushed a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
…nate#2643) Fixes nhibernate#2642 Co-authored-by: maca88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case and fix for issue #2642
AddConstantExpressionParametermethod, added an extra parameter to "override" the value instead of always usingexpression.ValueTested with SQL Server and PostgreSQL.