Fix subquery "Item with Same Key has already been added” exception for Linq provider #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Feb 4, 2021
| @@ -317,8 +317,8 @@ protected HqlTreeNode VisitBinaryExpression(BinaryExpression expression) | |||
| var rightType = GetExpressionType(expression.Right); | |||
| if (leftType != null && leftType == rightType) | |||
| { | |||
| _notCastableExpressions.Add(expression.Left, leftType); | |||
| _notCastableExpressions.Add(expression.Right, rightType); | |||
| _notCastableExpressions.TryAdd(expression.Left, leftType); | |||
There was a problem hiding this comment.
TryAdd is not available in .net standard 2.0 and .net 4.6.1
There was a problem hiding this comment.
Added an extension method for them.
There was a problem hiding this comment.
@maca88 can we replace Add with Set?
_notCastableExpressions[expression.Right] = rightType;
There was a problem hiding this comment.
Somehow I overlooked the comment. Yes we can, replaced with Set.
Also now I realized that I created the branch to this repository instead on my fork. We should remove the branch after merging.
There was a problem hiding this comment.
Somehow I overlooked the comment.
This is what I thought.
fredericDelaporte
approved these changes
Feb 6, 2021
|
@maca88 one last question from me, see in the comments section. |
hazzik
approved these changes
Feb 10, 2021
bahusoid
pushed a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
…r Linq provider (nhibernate#2664) Fixes nhibernate#2659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2659