Skip to content

Fix decimal equality comparison for Sqlite #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2021
Merged

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Jun 2, 2021

It is a fix for a regression made by #2335.

Fixes #2792

@maca88 maca88 changed the title Fix decimal equality comparison for Sqlite WIP - Fix decimal equality comparison for Sqlite Jun 3, 2021
@fredericDelaporte fredericDelaporte added this to the 5.3.9 milestone Jun 6, 2021
Copy link
Member

@bahusoid bahusoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why WIP? Fix looks complete to me

@maca88 maca88 changed the title WIP - Fix decimal equality comparison for Sqlite Fix decimal equality comparison for Sqlite Jun 15, 2021
@maca88
Copy link
Contributor Author

maca88 commented Jun 15, 2021

I forgot to remove it.

@hazzik hazzik merged commit 13e0f10 into nhibernate:5.3.x Jun 16, 2021
bahusoid pushed a commit to bahusoid/nhibernate-core that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arithmetic operations adding casts to SQLite that cause incorrect results
4 participants