Skip to content

Cache Dialect in tests #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2021
Merged

Cache Dialect in tests #2851

merged 2 commits into from
Jul 25, 2021

Conversation

bahusoid
Copy link
Member

No description provided.

@hazzik
Copy link
Member

hazzik commented Jul 12, 2021

Any actual improvements?

@bahusoid
Copy link
Member Author

Any actual improvements?

Negligible on CI builds. It's just doesn't feel right to create new dialect on each property access.

@hazzik hazzik added this to the next minor milestone Jul 25, 2021
@hazzik hazzik merged commit a97627d into nhibernate:master Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests p: Lowest r: Fixed t: Task
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@bahusoid @hazzik