Run tests on .NET 6 #2951
Run tests on .NET 6 #2951
Conversation
src/NHibernate.Test/Async/StaticProxyTest/InterfaceHandling/Fixture.cs
Outdated
Show resolved
Hide resolved
| <ContentSQLiteInteropFiles>true</ContentSQLiteInteropFiles> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(TargetFramework)' == 'netcoreapp2.0'"> | ||
| <PropertyGroup Condition="'$(TargetFramework)' == 'net6.0'"> |
There was a problem hiding this comment.
Why not introduce global NhNetCore property and use it for all such places instead to simplify further retargeting?
There was a problem hiding this comment.
Because this is not so easy... I tried it when targeting both .NET Core 3.1 and .NET 6... The dependencies could/were a little different. For example, Microsoft.AspNetCore.OData does not have problems on 3.1 but has problems in 6.0.
There was a problem hiding this comment.
Ehm... I want to convert checks like <PropertyGroup Condition="'$(TargetFramework)' == 'net6.0'"> to something like <PropertyGroup Condition="NhNetCore">. Looks easy enough for me.. Not sure I understand your problem - are you talking about targeting both 3.1 and 6.0? IMO that's a bit different issue and should be handled separately
There was a problem hiding this comment.
Looks easy enough
Yes, it is easy, but I doubt it will solve any real issue.
are you talking about targeting both 3.1 and 6.0?
I was going to make it target .NET 3.1 and .NET 6 rc initially. I started working on the switch around last betas and before .NET 6 rc.1 came out. But I did not have enough time and motivation to finish that at that time. So because of differences in the supported features (like SYSLIB0011 - BinaryFormatter depreciation which is quite aggressive) and different dependencies between .NET 3.1 and .NET 6.0 it required having 2 different monikers like NhNetCore31 and NhNet60. Which defied the purpose of the simplification.
Also, the same could happen when we transition from .NET 6 to next version. Depends on the path we're willing to take.
So, frankly, I do not believe that a simple bump of a version in NhNetCore would be enough to migrate to the later versions. Seems like we're trying to solve the problem which we might not have.
For NhNet it does have sense to use it because Microsoft has promised that 4.x API would stay backwards compatible.
…into net6.0-tests
src/NHibernate.Test/Async/Insertordering/FamilyModel/Fixture.cs
Outdated
Show resolved
Hide resolved
src/NHibernate.Test/Async/Insertordering/InsertOrderingFixture.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
Just noticed that Rider no longer recognizes symbols from ANTLR generated code. Is it only me or I wonder if it's somehow related to .NET 6 SDK that I recently installed For instance HqlSqlWalker no longer sees generated constants: |
|
Same here. Probably issue with Rider. Probably worth to create a ticket in their issue tracker. |
|
|
||
| <DisableImplicitPackageTargetFallback>True</DisableImplicitPackageTargetFallback> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(IsPackable)' == 'True'"> |
There was a problem hiding this comment.
What this $(IsPackable) about? I don't think it works properly. At least it seems all this information is now missing in generated nuget package
There was a problem hiding this comment.
@bahusoid. '$(IsPackable)' evaluates to 'true' instead of 'True'.
There was a problem hiding this comment.
Should be fixed here: #3125
No description provided.